next »

[Zim]

I did a search first and did not come up with anything.
Also I confess I think I am running 3.1, but did not see anything in the 3.2 upgrade to invest the effort in many file compares (I made some changes) (and the only recurring events update I saw was for Sundays)

Anyway, I'm seeing something wierd with recurring events.

Searching events.txt, I have 2 event entries.. #2, and #3.  #2 is for a recurring event that recurs on the 1st Tues of every month.  #3 is an event that recurs on the 3rd Tues of the month.

But, when I go to the "Edit Events" screen, I see event #2 listed approx 20 times! (I modified the Edit Events template to always show to event ID to help me track this down, using the if $search as my clue)

      ID     Start Date - Time     Event Title
   2    05 - 7:00 pm    *General Membership Meeting
   2    05 - 7:00 pm    *General Membership Meeting
   2    02 - 7:00 pm    *General Membership Meeting
   2    07 - 7:00 pm    *General Membership Meeting
   2    04 - 7:00 pm    *General Membership Meeting
   2    02 - 7:00 pm    *General Membership Meeting
   2    06 - 7:00 pm    *General Membership Meeting
   2    03 - 7:00 pm    *General Membership Meeting
   2    01 - 7:00 pm    *General Membership Meeting
   2    05 - 7:00 pm    *General Membership Meeting
   2    03 - 7:00 pm    *General Membership Meeting
   2    07 - 7:00 pm    *General Membership Meeting
   2    04 - 7:00 pm    *General Membership Meeting
   2    04 - 7:00 pm    *General Membership Meeting
   2    01 - 7:00 pm    *General Membership Meeting
   2    06 - 7:00 pm    *General Membership Meeting
   2    03 - 7:00 pm    *General Membership Meeting
   2    01 - 7:00 pm    *General Membership Meeting
   2    05 - 7:00 pm    *General Membership Meeting
   2    02 - 7:00 pm    *General Membership Meeting

Event id #3 does not show this odd behaviour.

As a caveat, this does NOT occur if I do a search (for "General").

Ideas?

thanks,
Mike

[This message has been edited by Zim (edited September 25, 2003).]

[Zim]

I've updated to 3.2, and still shows up this way.

I've now seen it on another recurring event too.

Mike

------------------

[Zim]

Well here is pass #1 at a patch.  I keep a hash of event ids, setting a 1 as the value when an event id is printed.  If the value is already 1, then its already been seen and is skipped.

This is in the routine getEvents in lib/Events.inc

code:

 $event_details = &getEventDetails($events_db,$event_ids);
        # patch to remove multiple recurring events in Edit events list
        my $mzcount = 0;
        my %mzlist;
        # end mz part a
        foreach $s (@$schedule) {
                # Skip the event unless it's approved
                next unless ($event_details->{$s->{'event_id'}}->{'approved'});
                # Skip if it's private
                next if ($event_details->{$s->{'event_id'}}->{'private'});
                # mz part b
                my $mzid = $event_details->{$s->{'event_id'}};
                next if ($mzlist{"$mzid"} == 1);
                $mzlist{"$mzid"} = 1;
                # end patch
                # If showing only my events, skip if I'm not the author
                if ($properties->{'my_events'}) {
                        next unless ($event_details->{$s->{'event_id'}}->{'author_id'} eq $main::User->{'username'});
                        }
                push(@$events, { 'schedule'=>$s, 'details'=>$event_details->{$s->{'event_id'}} } );
                }
        return $events;
        }

------------------